fix(sqllab): Allow router navigation to explore#25941
Merged
justinpark merged 2 commits intoapache:masterfrom Nov 14, 2023
Merged
fix(sqllab): Allow router navigation to explore#25941justinpark merged 2 commits intoapache:masterfrom
justinpark merged 2 commits intoapache:masterfrom
Conversation
justinpark
added
the
v3.1
josedev-union
pushed a commit
to Ortege-xyz/studio
that referenced
this pull request
Jan 22, 2024
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🏷️ bot
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Follow up #25151, this commit updates the "Create Chart" action in SQL Lab result panel by router navigation. It also keeps the option to open in new window forcefully (/w window/cmd key click).
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
before--spa-explore-link.mov
After:
after--spa-explore-link.mov
TESTING INSTRUCTIONS
Run a query in SQL Lab and then click "Create Chart"
ADDITIONAL INFORMATION